Open
Conversation
🦋 Changeset detectedLatest commit: 932d501 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This change removes the Textarea component from the @primer/styled-react package.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated Textarea wrapper/export from the @primer/styled-react package, including its implementation file and related test/snapshot updates.
Changes:
- Removed
Textarea/TextareaPropsexports frompackages/styled-react/src/index.tsx. - Deleted
packages/styled-react/src/components/Textarea.tsxand removed the corresponding browser test. - Updated the styled-react exports snapshot; updated Copilot PR-creation guidance.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/styled-react/src/index.tsx | Stops exporting Textarea and TextareaProps from @primer/styled-react. |
| packages/styled-react/src/components/Textarea.tsx | Deletes the styled-components wrapper around @primer/react’s Textarea. |
| packages/styled-react/src/tests/primer-react.browser.test.tsx | Removes the browser test asserting Textarea supports the sx prop. |
| packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updates export snapshot to remove Textarea. |
| .github/copilot-instructions.md | Adds guidance requiring PR descriptions to follow the repo’s PR template. |
hectahertz
approved these changes
Mar 24, 2026
Contributor
hectahertz
left a comment
hectahertz
left a comment
There was a problem hiding this comment.
Removal looks clean, no leftover references.
Two things:
- Should the changeset be
major(orminor) instead ofpatch? This deletes a public export, so anyone importingTextareafrom@primer/styled-reactwill break on upgrade. Zero usage per primer-query, but semver-wise it's still a breaking change. - The
.github/copilot-instructions.mdchange (PR template instruction) seems unrelated, might be cleaner in its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes the
Textareacomponent and its related exports from the@primer/styled-reactpackage. The component is not used anymore https://primer-query.githubapp.com/?query=package%3A%22%40primer%2Fstyled-react%22+name%3A%22Textarea%22Changelog
New
None
Changed
None
Removed
TextareaandTextareaPropsexports from@primer/styled-reactpackages/styled-react/src/components/Textarea.tsxTextareatest fromprimer-react.browser.test.tsxRollout strategy
Testing & Reviewing
Textareasxprop support removedMerge checklist